refac(dayjs): refactoring duration internal constants

[ssi02014]

Hello 👋 @iamkun Thank you for sharing such a great library.

It would be nice to have MILLISECONDS_A_YEAR and MILLISECONDS_A_MONTH inside duration managed together in "constants.js", what do you think?

[ssi02014]

I initialized it to null to explicitly write that the value is currently empty.

[iamkun]

any reason to initialize it to null, can we simply use let $d?

[ssi02014]

@iamkun
Yes, my initial intention was to explicitly initialize null to indicate that there is no current value, but I'll revert back to that.

[okinawaa]

good👍

[iamkun]

The reason to have a constant in duration plugin rather than in the common constant is that the src/constant will be bundled to the core package, not to the plugin, which will increase the package size.

[ssi02014]

@iamkun

The reason to have a constant in duration plugin rather than in the common constant is that the src/constant will be bundled to the core package, not to the plugin, which will increase the package size.

Does this make a big difference in package size?
I thought it would be better to manage them together in line with the purpose of constants.

[iamkun]

@iamkun

The reason to have a constant in duration plugin rather than in the common constant is that the src/constant will be bundled to the core package, not to the plugin, which will increase the package size.

Does this make a big difference in package size? I thought it would be better to manage them together in line with the purpose of constants.

This is because not everyone needs the duration plugin, and should not download these constants in the core module

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2254635) 100.00% compared to head (f811a89) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2403   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          183       183           
  Lines         2249      2249           
  Branches       636       636           
=========================================
  Hits          2249      2249           

Files Changed	Coverage Δ
src/plugin/duration/index.js	100.00% <ø> (ø)
src/constant.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ssi02014]

@iamkun I understand, I thought it was a very small difference. 🙏