Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Google and Twitter SVGs #175

Closed
wants to merge 2 commits into from
Closed

Conversation

ccorcos
Copy link

@ccorcos ccorcos commented Apr 30, 2020

As I commented in #174 I'd like some larger emoji images (I'm rendering some 78px emojis in some places and with a retina display, that requires 156px).

I noticed that once we get up to pngs that large, the SVGs are actually smaller. I notices that Google and Twitter provide SVG so I modified two scripts to collect them into this repository: build/google/makeSvg.sh and build/twitter/grab.php.

Note: First time ever using PHP

I don't know much about TTC fonts, but ideally we could extract Apple SVGs as well. Any ideas how to do that?

Also, it might make sense to integrate these in the build pipeline for emoji-datasource-google and emoji-datasource-twitter.

Thanks!

@mikecann
Copy link

Also very keen on getting SVG's any reason this isnt merged?

@ccorcos
Copy link
Author

ccorcos commented Jul 17, 2021

No one has ever responded...

@mikecann
Copy link

@iamcal Any reason why this cant be merged?

@iamcal
Copy link
Owner

iamcal commented Jul 28, 2021

Sorry for not responding sooner - The Apple emoji font uses bitmaps, not vectors/SVG, so there's no way to get SVGs for either Apple or Facebook images. As a result, I don't think it makes sense for this library to include SVG images. The purpose of this library is to make it easy to use bitmap'd emoji from the various icon sets, either as sheets or as individual images. If you want to use the SVGs from either Twemoji or Noto, then you can just use them directly from those projects.

@iamcal iamcal closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants