Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support core modules with node: prefix #27

Merged
merged 1 commit into from
Aug 15, 2022
Merged

feat: support core modules with node: prefix #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resolvewithplus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const require = module.createRequire(import.meta.url);
// which is also used by nodejs' internal resolver
const realpath = fs.realpathSync.native;
const isBuiltinRe = new RegExp(
'^('+module.builtinModules.join('|').replace('/', '\/')+')$');
'^(?:node:)?('+module.builtinModules.join('|').replace('/', '\/')+')$');
const isDirPathRe = /^\.?\.?(\/|\\)/;
const isRelPathRe = /^.\.?(?=\/|\\)/;
const isSupportedIndexRe = /index.[tj]sx?$/;
Expand Down
5 changes: 5 additions & 0 deletions tests/tests-basic/tests-basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ test('should return a core module reference as require.resolve id', () => {
assert.strictEqual(resolvewithplus('path'), 'path');
});

// eslint-disable-next-line max-len
test('should return a core module prefixed with \'node:\' reference as require.resolve id', () => {
assert.strictEqual(resolvewithplus('node:path'), 'node:path');
});

test('should return a full path when given relative path to index file', () => {
const fullpath = path.resolve('../testfiles/');
const indexPath = path.resolve('../testfiles/path/to/indexfile/index.js')
Expand Down