Merge pull request #27 from gmahomarf/feat/support-core-modules-with-…

…node-prefix feat: support core modules with `node:` prefix
iambumblehead · Aug 15, 2022 · bb56586 · bb56586
2 parents bfb36fe + 4bd9a46
commit bb56586
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/resolvewithplus.js b/resolvewithplus.js
@@ -8,7 +8,7 @@ const require = module.createRequire(import.meta.url);
 // which is also used by nodejs' internal resolver
 const realpath = fs.realpathSync.native;
 const isBuiltinRe = new RegExp(
-  '^('+module.builtinModules.join('|').replace('/', '\/')+')$');
+  '^(?:node:)?('+module.builtinModules.join('|').replace('/', '\/')+')$');
 const isDirPathRe = /^\.?\.?(\/|\\)/;
 const isRelPathRe = /^.\.?(?=\/|\\)/;
 const isSupportedIndexRe = /index.[tj]sx?$/;

diff --git a/tests/tests-basic/tests-basic.test.js b/tests/tests-basic/tests-basic.test.js
@@ -12,6 +12,11 @@ test('should return a core module reference as require.resolve id', () => {
   assert.strictEqual(resolvewithplus('path'), 'path');
 });
 
+// eslint-disable-next-line max-len
+test('should return a core module prefixed with \'node:\' reference as require.resolve id', () => {
+  assert.strictEqual(resolvewithplus('node:path'), 'node:path');
+});
+
 test('should return a full path when given relative path to index file', () => {
   const fullpath = path.resolve('../testfiles/');
   const indexPath = path.resolve('../testfiles/path/to/indexfile/index.js')