fix: no onSelect event when same item selected

[iambumblehead]

No description provided.

[github-actions]

🎊 PR Preview c79b742 has been successfully built and deployed to https://iambumblehead-react-dropdown-now-preview-pr-102.surge.sh

🕐 Build time: 173.451s

_{🤖 By surge-preview}

[iambumblehead]

@lwhiteley changes here are for this ticket #96

[iambumblehead]

@lwhiteley the more I think about it... the current behaviour before the changes here seems correct. Maybe we should close the issue and update the test to verify that onSelect is called even when the value is the same.

What do you think?

[lwhiteley]

Think the issue is that the events should not be triggered when there is no user interaction

[iambumblehead]

@lwhiteley I had the same impression at first and I even added a test that rendered two dropdowns referencing the same value --changing one dropdown did not change the value or trigger events at the other dropdown. I could re-add that test.

[iambumblehead]

@lwhiteley upon second thought, the two-dropdowns tests used a primitive value "one" and maybe using an object value instead triggers the onChange event.

[iambumblehead]

I'll add the two-dropdowns test in a few hours

[iambumblehead]

@lwhiteley please review

[iambumblehead]

@lwhiteley I was able to reproduce the issue. Changing the value of the second dropdown triggered onChange at the first dropdown. To resolve it, the dropdown reads the event target to detect if the event originates at the dropdown.

[iambumblehead]

There could issues if the dropdown later needed to support keyboard selection and input, but if you're OK with the current change I will be too.

[iambumblehead]

do you use Matrix @lwhiteley? https://matrix.org/clients/

[lwhiteley]

do you use Matrix @lwhiteley? https://matrix.org/clients/

never heard of it. what would be the purpose of it?

[lwhiteley]

Can go with this for now and maybe review the entire composition in a next major version

[lwhiteley]

never heard of it. what would be the purpose of it?

actually seems i have used it without knowing. i used gitter.im before. You can create rooms for git repositories

[iambumblehead]

@lwhiteley this page has a little blurb describing matrix https://tatsumoto-ren.github.io/blog/join-our-community.html

Matrix is great because it's completely libre and federated, and you don't need an email address, or a phone number to make an account. Just type your name and a password, and you're in! Before you join, install a Matrix client and register an account on any server that is not matrix.org.

I know about it because there are clients for ubuntu touch and gnome3, which I use on my phone and desktop. Also, I like messaging applications and have been building a service that follows the matrix spec in many parts. I would like to be your friend on Matrix or another messaging system.

[lwhiteley]

can chat privately on https://gitter.im/

and discuss further

[iambumblehead]

I signed in there with my github proifile and if I type "lwhi" or "whit" it doesn't auto-complete "lwhitely" there.