Update test and README about tsx compatibility #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galexite
force-pushed
the
tsx-is-now-compatible
branch
from
05d2154 to
5611727
Compare
tsx has been compatible with other loaders since around the end of 3.x and the start of 4.x when the aforementioned issue privatenumber/tsx#264 was resolved. Update the test to use a newer version of tsx which does not exhibit the bug and the README to say tsx is compatible.
galexite
force-pushed
the
tsx-is-now-compatible
branch
from
5611727 to
cdd1292
Compare
|
the failing test is likely due to the node upstream bug mentioned here #304 thanks for the PR will merge and publish later today edit yes the issue is with node upstream; all tests pass using node 22.1.x |
|
I tried running the tsx tests different times since that issue was closed, but this is the first time I have seen them pass. There were other tsx issues that prevented tsx from working, even after url-params-issue was resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsx has been compatible with other loaders since around the end of 3.x and the start of 4.x when the aforementioned issue privatenumber/tsx#264 was resolved.
Update the test to use a newer version of tsx which does not exhibit the bug and the README to say tsx is compatible.