Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch exceptions generated by pnpapi #262

Merged
merged 2 commits into from
Oct 23, 2023
Merged

catch exceptions generated by pnpapi #262

merged 2 commits into from
Oct 23, 2023

Conversation

koshic
Copy link
Collaborator

@koshic koshic commented Oct 23, 2023

When we try to mock non-existent files, Yarn PnP throws an exception in pnpapi.resolveRequest. It's safe to ignore it and return null, 'module not resolved, sorry'.

@koshic koshic requested a review from iambumblehead October 23, 2023 16:28
@koshic
Copy link
Collaborator Author

koshic commented Oct 23, 2023

@iambumblehead it would be nice if you can release new version today or tomorrow. thx!

Copy link
Owner

@iambumblehead iambumblehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@iambumblehead
Copy link
Owner

I saw this 10 min ago but needed to attend to something else sorry for the delay ... we could merge and publish right away

@iambumblehead iambumblehead merged commit 58f3b6d into main Oct 23, 2023
10 checks passed
@iambumblehead iambumblehead deleted the pnp-resolver-fix branch October 23, 2023 16:41
@iambumblehead
Copy link
Owner

I don't remember my npm credentials right now and it could be a headache trying to login there but if you have an npm profile I could try adding you as a maintainer there next time I login so that you could publish. cc @koshic

To publish I just pull the latest main sources and run npm publish and it automatically minifies, runs the unit-tests and finally publishes everything

@koshic
Copy link
Collaborator Author

koshic commented Oct 23, 2023

@iambumblehead
Copy link
Owner

bumble@duck esmock月$ npm owner add grenaderov esmock
npm notice INFO: User grenaderov invited to package esmock successfully.
+ grenaderov (esmock)
bumble@duck esmock月$ npm owner add grenaderov resolvewithplus
npm notice INFO: User grenaderov invited to package resolvewithplus successfully.
+ grenaderov (resolvewithplus)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants