-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add assert function, assert import.meta.resolve returns string or null #236
Conversation
Nice hotfix, thank you! In general it would be nice to detect --experimental-import-meta-resolve flag once instead of asserting return value (and using expensive throw -> catch mechanics) on every 'resolve' call. |
@koshic locally, the assertion resolves most tests here that do not use the --experimental flag. Possibly import.meta.resolve is broken with and without the --experimental flag and, if import.meta.resolve is fixed upstream, esmock could remove the assertion and error. I'm first trying to resolve tests without --experimental and, when those are passing, try to resolve issues that occur when --experimental is used. |
Sure, this is why I approved that PR :) |
yes you are right |
My mental powers are not strong today and I misunderstood several things but am reading more carefully. Thanks for your patience. |
closing this in favor of #237 |
closes #234