Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse moduleidre #231

Merged
merged 8 commits into from
Aug 15, 2023
Merged

reuse moduleidre #231

merged 8 commits into from
Aug 15, 2023

Conversation

iambumblehead
Copy link
Owner

@iambumblehead iambumblehead commented Aug 15, 2023 •
edited
Loading

  • reuse one regexp rather than create separate regexps
  • remove esmockIsLoader.js file, export that from esmockLoader.js instead

@iambumblehead iambumblehead requested a review from koshic August 15, 2023 07:35
koshic
koshic requested changes Aug 15, 2023
View reviewed changes
src/esmockLoader.js Outdated Show resolved Hide resolved
@iambumblehead iambumblehead merged commit facd5b1 into master Aug 15, 2023
@iambumblehead iambumblehead deleted the reusable-moduleidre branch August 15, 2023 16:08
@iambumblehead iambumblehead mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koshic koshic koshic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iambumblehead @koshic @bumblehead