-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation controller root bug #74
Conversation
Co-authored-by: Nataliya Patsovska <[email protected]>
Looks like the |
Co-authored-by: Nataliya Patsovska <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This will be a patch I suppose. Feel free to bump the version in the same PR. We need to update issue 40 to include the navigation controller too.
This PR fixes a set of subtle problems experienced when a
UINavigationController
is presented in a modal context. The initial presentation wasn't performed immediately, and some kind of lifecycle issue caused input cursors forUITextField
instances in the first view controller to be missing from the view hierarchy.The issue could be solved by assigning an explicit root view controller, which lead to the discovery of the problem here in Presentation - likely introduced when creating the workaround for issue #40 in iOS 13+ without considering
UINavigationController
. This PR also fixes a minor issue found when setting up the dismiss action for these flows.