add setup node to finalize-release.yaml #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRod1999
requested review from
aruniverse,
calebmshafer,
wgoehrig and
ColinKerr
as code owners
|
this is the only place where we need to do this? |
most of our ado pipelines already have this for core already. Otherwise I'm pretty sure we would have experienced breakages from Gytis' PR. |
aruniverse
reviewed
Nov 21, 2024
|
linking https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md as an fyi re what ver of node is being used by the image |
aruniverse
approved these changes
Nov 22, 2024
|
@Mergifyio backport release/4.10.x release/4.11.x |
✅ Backports have been created
|
aruniverse
approved these changes
Nov 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Daniel Rodriguez <[email protected]> (cherry picked from commit 1fbf7df)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Daniel Rodriguez <[email protected]> (cherry picked from commit 1fbf7df)
DanRod1999
added a commit
that referenced
this pull request
Nov 22, 2024
…1.x] (#7420) Co-authored-by: Daniel Rodriguez <[email protected]>
DanRod1999
added a commit
that referenced
this pull request
Nov 22, 2024
…0.x] (#7419) Co-authored-by: Daniel Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setup node step to pipeline. Otherwise we run the risk of a vm not using a supported version of node.
This caused an error in another pipeline, so we should use node setup or nodeTool whenever possible to avoid this problem