Presentation: Can't remove related properties from supplemental rulesets #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigasp
requested changes
Apr 25, 2022
grigasp
approved these changes
Apr 28, 2022
…FromSupplementalRulesets
Alina657
deleted the
presentation/CantRemoveRelatedPropertiesFromSupplementalRulesets
branch
pmconne
added a commit
that referenced
this pull request
May 4, 2022
* Support unquantized vertex tables (#3495) * Shader variants for unquantized vertex tables (#3445) * switch back to unquantized vertex tables for decoration graphics. * technique flag for unquantized vs quantized positions. * Unquantized technique variants. * update early z flags. * propagate position type to vertex shader builder. * don't bother updating unused uniform * additional vertex data * read unquantized positions. * color * edge * polyline * surface. * Turn on unquantized vertex tables for decorations. They mostly don't draw properly or at all. Point strings look like they work. * typo * adjust expected vertex size * Choose unquantized shaders where appropriate. * Remove spurious assertion - will fail if previous mesh produced no graphics. * remove u_qOrigin/Scale from shaders that don't need them. * further cleanup of shader code. * further cleanup of shader code. (cherry picked from commit c6781fa) * tile specifies unquantized positions. * keyin to generate element graphics. * Presentation: Can't remove related properties from supplemental rulesets (#3547) * Documentation for bug fixes * Code review fixes Co-authored-by: Alina Paliulionyte <[email protected]> * @bentley/imodeljs-native 3.2.7 * extract-api Co-authored-by: imodeljs-admin <[email protected]> Co-authored-by: Grigas <[email protected]> Co-authored-by: Michel D'Astous <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: markschlosseratbentley <[email protected]> Co-authored-by: Seamus Kirby <[email protected]> Co-authored-by: Daniel Toby <[email protected]> Co-authored-by: Bill Steinbock <[email protected]> Co-authored-by: TitouanLeDuigou <[email protected]> Co-authored-by: Arun George <[email protected]> Co-authored-by: Arun George <[email protected]> Co-authored-by: AlainRobertAtBentley <[email protected]> Co-authored-by: Saulius Skliutas <[email protected]> Co-authored-by: Spencer Barnes <[email protected]> Co-authored-by: kckst8 <[email protected]> Co-authored-by: johnnyd710 <[email protected]> Co-authored-by: NancyMcCallB <[email protected]> Co-authored-by: Eimantas Morkūnas <[email protected]> Co-authored-by: nick4598 <[email protected]> Co-authored-by: Michael Belousov <[email protected]> Co-authored-by: MindaugasButkus <[email protected]> Co-authored-by: dassaf4 <[email protected]> Co-authored-by: Bill Goehrig <[email protected]> Co-authored-by: Michael Belousov <[email protected]> Co-authored-by: Colin Kerr <[email protected]> Co-authored-by: DStradley <[email protected]> Co-authored-by: Akshay Nangare <[email protected]> Co-authored-by: Robert Lukasonok <[email protected]> Co-authored-by: christophermlawson <[email protected]> Co-authored-by: Caleb Shafer <[email protected]> Co-authored-by: MarcBedard8 <[email protected]> Co-authored-by: GerardasB <[email protected]> Co-authored-by: williamkbentley <[email protected]> Co-authored-by: MarcNeely <[email protected]> Co-authored-by: Paulius Valiūnas <[email protected]> Co-authored-by: bbastings <[email protected]> Co-authored-by: AJMigliore <[email protected]> Co-authored-by: Travis Cobbs <[email protected]> Co-authored-by: mgooding <[email protected]> Co-authored-by: Alina Paliulionytė <[email protected]> Co-authored-by: Alina Paliulionyte <[email protected]> Co-authored-by: Martynas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for fixed bugs.
https://dev.azure.com/bentleycs/iModelTechnologies/_git/imodel02/pullrequest/244298