Improved validation of ESRI services before adding map layer (#3321)

* Validate ESRI service supports 'Map' requests before making further tile requests. * changelog
iTwin · Mar 9, 2022 · 9072a11 · 9072a11
1 parent 935bc6e
commit 9072a11
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/common/changes/@itwin/core-frontend/geo-validateEsriMapService_2022-03-08-20-15.json b/common/changes/@itwin/core-frontend/geo-validateEsriMapService_2022-03-08-20-15.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-frontend",
+      "comment": "Improved validation of ESRI services before adding map layer",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-frontend"
+}
diff --git a/core/frontend/src/tile/map/ArcGisUtilities.ts b/core/frontend/src/tile/map/ArcGisUtilities.ts
@@ -140,6 +140,19 @@ export class ArcGisUtilities {
         return { status: MapLayerSourceStatus.InvalidCredentials, authInfo: { authMethod: MapLayerAuthType.EsriToken } };
     }
 
+    // Check this service support map queries
+    let hasMapCapability = false;
+    try {
+      if (json.capabilities
+        && typeof json.capabilities === "string"
+        && json.capabilities.toLowerCase().includes("map")) {
+        hasMapCapability = true;
+      }
+    } catch { }
+    if (!hasMapCapability) {
+      return { status: MapLayerSourceStatus.InvalidFormat};
+    }
+
     let subLayers;
     if (json.layers) {