Update to ESLint 9.11 and typescript-eslint 8.8 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruniverse
reviewed
Oct 3, 2024
| "@typescript-eslint/eslint-plugin": "~8.8.0", | ||
| "@typescript-eslint/parser": "~8.8.0", | ||
| "eslint-formatter-visualstudio": "^8.40.0", | ||
| "eslint-plugin-import": "^2.30.0", | ||
| "eslint-plugin-jam3": "^0.2.3", |
There was a problem hiding this comment.
wonder if we should remove this, hasnt been touched in 5 yrs
There was a problem hiding this comment.
does this eslint rule seem silly?
should this be handled by prettier or some other formatter?
aruniverse
reviewed
Oct 3, 2024
| "@typescript-eslint/typedef": "off", | ||
| "@typescript-eslint/unbound-method": "error", | ||
| "@typescript-eslint/unified-signatures": "error", | ||
| // FIXME: Do we want to migrate to @stylistic/eslint-plugin-ts? |
There was a problem hiding this comment.
i would lke to vote for no, and defer to using a formatter like prettier or biome or something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ESLint v8.x reaches end of life this weekend, it's time for us to start work on updating to v9.
This is currently blocked waiting on two dependencies to update:
So far I've only tested these changes in itwinjs-core.
We will also need to decide what to do about stylistic rules - these have moved out of typescript-eslint to @stylistic/eslint-plugin-ts, but the stylistic rules overall are discouraged by typescript-eslint. We may want to consider prettier or dprint...