introducing confetti animation using konfetti library #1743

gokulk16 · 2023-06-16T13:46:32Z

Added Konfetti library: https://github.com/DanielMartinus/Konfetti

Test cases when confetti will be shown for habit type - boolean(Yes/No):

Toggling with the short press
Toggling inside the checkmark pop-up

Test cases when confetti will be shown for habit type - measurable:

Adding an entry using the number pop-up. animation shows even when the number doesn't match the target for the day respecting the progress made on the day for the user.

Settings combinations tested with:

skip days disabled; toggle with short press disabled
skip days disabled; toggle with short press enabled
skip days enabled; toggle with short press disabled
skip days enabled; toggle with short press enabled

Screen recording of confetti animation:

Confetti.recording.in.nexus.4.mp4

hiqua

Just a superficial look at the code for now.

hiqua · 2023-07-03T21:32:57Z

uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt

@@ -100,5 +102,11 @@ class NumberDialog : AppCompatDialogFragment() {
        val notes = view.notes.text.toString()
        onToggle(value, notes)
        requireDialog().dismiss()
+        val v = requireActivity().findViewById<LinearLayout>(R.id.konfettiLayout)


v is called konfettiView above, consistency?

hiqua · 2023-07-03T21:33:26Z

uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt

@@ -100,5 +102,11 @@ class NumberDialog : AppCompatDialogFragment() {
        val notes = view.notes.text.toString()
        onToggle(value, notes)
        requireDialog().dismiss()
+        val v = requireActivity().findViewById<LinearLayout>(R.id.konfettiLayout)
+
+        if (value > 0.0) {


Maybe it should be on completion rather than for any value? Not sure.

added a code comment.

Reason: I thought it would be motivating for users to at least add some value rather than not doing the habit. 😸

hiqua · 2023-07-03T21:35:44Z

...android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt

@@ -88,25 +89,28 @@ class CheckmarkButtonView(
        setOnLongClickListener(this)
    }

-    fun performToggle() {
+    fun performToggle(v: View) {


Same remark about this v variable, make it more explicit so that it's easier to understand.

…erence errors

ezio-melotti · 2023-07-12T05:01:24Z

uhabits-android/src/main/java/org/isoron/uhabits/utils/ViewExtensions.kt

+}
+
+fun showConfetti(view: View) {
+    val viewId = R.id.konfetttiView


Suggested change

val viewId = R.id.konfetttiView

val viewId = R.id.konfettiView

Is this a typo or is there a reason to have 3 t?

not typo, i was just using 3 t to differentiate the variables in kt files and in XML. Just a minor naming convention

ezio-melotti · 2023-07-12T05:01:39Z

uhabits-android/src/main/res/layout/konfetti.xml

+    <nl.dionsegijn.konfetti.xml.KonfettiView
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:id="@+id/konfetttiView"/>


Suggested change

android:id="@+id/konfetttiView"/>

android:id="@+id/konfettiView"/>

gokulk16

fixed few comments, fixed conflicts and responded to some comments

gokulk16 · 2023-07-04T15:27:10Z

uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt

@@ -100,5 +102,11 @@ class NumberDialog : AppCompatDialogFragment() {
        val notes = view.notes.text.toString()
        onToggle(value, notes)
        requireDialog().dismiss()
+        val v = requireActivity().findViewById<LinearLayout>(R.id.konfettiLayout)
+
+        if (value > 0.0) {


added a code comment.

Reason: I thought it would be motivating for users to at least add some value rather than not doing the habit. 😸

gokulk16 · 2023-07-12T06:22:34Z

uhabits-android/src/main/java/org/isoron/uhabits/utils/ViewExtensions.kt

+}
+
+fun showConfetti(view: View) {
+    val viewId = R.id.konfetttiView


not typo, i was just using 3 t to differentiate the variables in kt files and in XML. Just a minor naming convention

hiqua · 2023-08-10T22:43:45Z

I think we'd need a new setting to allow users to disable this if they don't want this
what happens if you interact with the UI while the animation is working, does it still work? Does it interrupt the animation?
maybe something a bit more discrete would be better

I don't want to tell you to do 1. yet because I'm still not sure @iSoron is open to this new UI feature, better to wait for a confirmation first. @iSoron can you give us your opinion (e.g. based on the video) before @gokulk16 continues working on this?

neube3 · 2024-01-01T18:24:22Z

Just wanted to chip in that the lack of a strong blue colour (e.g. 0000FF) in that confetti would make me not use it. It's not confetti without all primary colours. (Only half-joking)

iSoron · 2024-04-03T00:58:46Z

Thank you for the PR, @gokulk16. I have merged it to dev (06090e2) with the following major changes:

Move the Konfetti code to ListHabitsScreen
Make the confetti originate from the button, instead of the center of the screen
Use the color of the habit as the base color for the confetti, but add some randomization, so we still get multiple colors
Tweak some animations, layout and the conditions in which the confetti is shown.

Feel free to submit other PRs to tweak it further or fix any remaining issues. At this point, I think the animation is subtle enough for it to be enable by default. If users complain about it, we can add an option in the settings to disable it, or even make it opt-in.

gokulk16 · 2024-04-03T05:28:09Z

@iSoron Thanks for the tweaks and also merging the PR. 🙏

introducing confetti animation using konfetti library

a2ae1fd

gokulk16 marked this pull request as draft June 18, 2023 12:52

gokulk16 marked this pull request as ready for review June 18, 2023 12:54

hiqua reviewed Jul 3, 2023

View reviewed changes

Gokul K added 4 commits July 4, 2023 18:50

fixing some comments from @hiqua

2fd7b44

fixed ktlint erorrs and is building successfully now

6901968

fixing another lint error

d643397

rendering only if layout and konfetti view exists - to avoid null ref…

48c0b39

…erence errors

ezio-melotti reviewed Jul 12, 2023

View reviewed changes

Merge branch 'dev' into dev

83328b0

gokulk16 commented Jul 29, 2023

View reviewed changes

gokulk16 requested review from hiqua and ezio-melotti July 29, 2023 04:56

hiqua assigned iSoron Aug 10, 2023

iSoron closed this Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introducing confetti animation using konfetti library #1743

introducing confetti animation using konfetti library #1743

gokulk16 commented Jun 16, 2023 •

edited

Loading

hiqua left a comment

hiqua Jul 3, 2023

hiqua Jul 3, 2023

gokulk16 Jul 4, 2023

hiqua Jul 3, 2023

ezio-melotti Jul 12, 2023

gokulk16 Jul 12, 2023

ezio-melotti Jul 12, 2023

gokulk16 left a comment

gokulk16 Jul 4, 2023

gokulk16 Jul 12, 2023

hiqua commented Aug 10, 2023 •

edited

Loading

neube3 commented Jan 1, 2024

iSoron commented Apr 3, 2024

gokulk16 commented Apr 3, 2024

	val viewId = R.id.konfetttiView
	val viewId = R.id.konfettiView

	android:id="@+id/konfetttiView"/>
	android:id="@+id/konfettiView"/>

introducing confetti animation using konfetti library #1743

introducing confetti animation using konfetti library #1743

Conversation

gokulk16 commented Jun 16, 2023 • edited Loading

hiqua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gokulk16 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiqua commented Aug 10, 2023 • edited Loading

neube3 commented Jan 1, 2024

iSoron commented Apr 3, 2024

gokulk16 commented Apr 3, 2024

gokulk16 commented Jun 16, 2023 •

edited

Loading

hiqua commented Aug 10, 2023 •

edited

Loading