Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9562 bmi166 acc readout #9563

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Dec 14, 2023

Looks like a typo on bmi160 code.

@DzikuVx this does not seem like a very popular IMU. It was only i in the RADIX target, which lacks a CMakeLists.txt.

The driver itself has been sitting, mostly unchanged for 6-7 years (except a few changes 7 months ago) which introduced this typo.

Reported in issue #9562

BMI160 is only used by the RADIX target, which lacks CMakeFileLists.txt
@mmosca mmosca requested a review from DzikuVx December 14, 2023 09:21
@mmosca mmosca changed the title Fix #9562 Fix #9562 bmi166 acc readout Dec 14, 2023
@mmosca mmosca added this to the 7.1 milestone Dec 14, 2023
@mmosca
Copy link
Collaborator Author

mmosca commented Dec 14, 2023

Upon further digging, radix target has been disabled since at least 2.4.0

@synersignart
Copy link

Looks like a typo on bmi160 code.

@DzikuVx this does not seem like a very popular IMU. It was only i in the RADIX target, which lacks a CMakeLists.txt.

The driver itself has been sitting, mostly unchanged for 6-7 years (except a few changes 7 months ago) which introduced this typo.

Reported in issue #9562

apparently Our Synerduino boards are using those and we inverted the X and Y axis as the chip set we got seems to have this arrangement

synerduino

@synersignart
Copy link

the INAV 6.1.0 version as this as well
image

@mmosca
Copy link
Collaborator Author

mmosca commented Dec 14, 2023

the INAV 6.1.0 version as this as well image

Does it work in inav 6.1.0?

@synersignart
Copy link

synersignart commented Dec 15, 2023

the INAV 6.1.0 version as this as well image

Does it work in inav 6.1.0?

yes after I change the orientation of the X and Y axis as you can see here. as for the code gyroRaw & accRaw it was correct
Commented : the original code
UnCommented : the modify code
this was done could simply be that the later BMI160 chips could have a different orientation between the Gyro and Acc that causes incorrect readings

side note:

Synerduino boards are using the BMI160 as well and active in the Philippine market.

@DzikuVx DzikuVx merged commit 3b218b6 into release_7.1.0 Dec 26, 2023
14 checks passed
@DzikuVx DzikuVx deleted the mmosca-9562-bmi160-acc-issue branch December 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants