Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make min ground speed setable a parameter #9428

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Oct 30, 2023

This PR changes the hard coded minimum ground speed of 7m/s to a parameter. The parameter is in m/s and can be set in the battery profile navigation settings. Default is the current 7 m/s.

Fixes #9405

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 1, 2023

Tested in HITL and everything seems to work as expected. For these tests, I set a 35Kt SW wind (220 degrees) at 500ft. All tests carried out with throttle stick all the way down (low).

With the default settings (original 7m/s). The throttle adjusted to average a 25kmh ground speed. Which is correct.
image

Increasing nav_min_ground_speed to 10 m/s (36kmh) averaged a ground speed of 36 kmh, with the same wind conditions.
image

Further increasing to 15 m/s resulted in an average 54 kmh ground speed.
image

@MrD-RC MrD-RC marked this pull request as ready for review November 1, 2023 21:23
@MrD-RC MrD-RC added this to the 7.1 milestone Nov 1, 2023
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 1, 2023

Decided it doesn't need to be in the battery profile. It's airframe related, not power. The weight of the battery doesn't matter, as this isn't anything to do with stall. It's about the speed over the ground and how well the airframe penetrates the air.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 2, 2023

The parameter has been removed from battery profiles, in to the basic nav settings. Need to test on the FC. But should all be ok.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 3, 2023

Tested in HITL. All good. All tests carried out with throttle stick all the way down.

7 m/s min ground speed
image

15 m/s min ground speed
image

@MrD-RC MrD-RC merged commit b39a2dc into master Dec 6, 2023
16 checks passed
@MrD-RC MrD-RC deleted the MrD_Make-min-ground-speed-a-parameter branch December 6, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum GPS air/3d speed for fixed wing navigation
1 participant