-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to include all baro drivers to target #9394
Conversation
Some fc don't include a baro, in that case we should include all drivers in the target, so the user has flexibility in choseing an external baro, without having to create a custom target. Downside is firmware size for f411/f722 devices.
Could this be something that's disabled on targets with flash < 512kb? If the space is an issue. |
This is mostly for fcs that don't have an onboard baro, as we have no idea what baro the users will try to use. It currently fits in 512kb targets, and needs to be added manually to the target anyway. I don't plan to do a bulk change of targets, as I have no idea which targets have an onboard baro or not. Having all these drivers does increase flash usage by about 1%, when comparing to no baro drivers. |
And just for the record, yes, it is possible to add #if (MCU_FLASH_SIZE <= 512) check to limit drivers to "most common", if we know what they are. |
1% is more than 1/3 (497Kb) of the currently available flash still remaining on 512Kb targets.. |
It is a balance on user friendliness and flash space. We have no way of knowing which baro they would use and a lot of users are not really that keen on building custom targets. |
For reference:
After change:
|
Some fc don't include a baro, in that case we should include all drivers in the target, so the user has flexibility in choseing an external baro, without having to create a custom target.
Downside is firmware size for f411/f722 devices.