Mixer throttle fixes/improvements + more OSD Throttle changes #9274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors parts of the mixer throttle code to clean up unnecessary calls to
getThrottleIdleValue
function. Also, improves throttle motor setting when disarmed or motor stopped.For the OSD throttle percent for the scaled option is now based on
mixerThrottleCommand
rather thanrcCommand[throttle]
since this better reflects what is actually sent to the motors. The OSD scaled throttle option now shows "IDLE", "STOP" and "DARM" rather than just "0" to make it clearer what the motor is actually doing. OSD change also remove the Scale symbol before the Throttle symbol for the scaled throttle field since it doesn't seem necessary given the additional messages make it clear this is the Scale option. Happy to reinstate but always thought it looked a bit odd and out of place and out of proportion to the Throttle symbol itself.