fixed beeper -ON_USB for 1S setup, fixed beeper -SYSTEM_INIT #9147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submit fixes two issues:
- beeper -ON_USB silences beeper completely on 1S setup.
IS:
getBatteryCount()<2
is used to check if battery is disconnectedSHOULD:
getBatteryState() == BATTERY_NOT_PRESENT
should be used instead.- beeper -SYSTEM_INIT does not disable system init sound.
IS:
SYSTEM_INIT
flag is read frombeeper PREFERENCES
for unknown reason.SHOULD:
getBeeperOffMask()
should be usedNote:
ON_USB
was described as silencing when USB is connected. Actually it silences when battery is disconnected (so FC is powered from USB).Note: System init sound is not influenced by
ON_USB
because system init sound is played before battery sensor is configured - Ok.Note: I guess that on some FCs battery sensor may (incorrectly) sense USB voltage, and thus battery sensor can detect 1S battery. Well, on these targets
ON_USB
will not work. From the beeper part, code is correct. If workaround is reqired, it should be in battery sensor code, not in beeper code:getBatteryState() == BATTERY_NOT_PRESENT
should work correctly.Sidenote: personally I would remove
beeper PREFERENCES
as redundand feature.