Pan Enhancements and cardinal markers for ESP32 Radar #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrD-RC I found those three arrows hard to correlate to the craft position. This will be a good improvment. |
|
Windows builds of the associated Configurator can be found here. |
The 1-3 arrows that hang off the side of the ESP32 Radar POIs are not intuitive for finding your flying buddies. This PR replaces the 1-3 arrows with a compass style cardinal indicator. This will point in the direction of the other craft. It is displayed on the right of the POI, to be distinct from the relative heading arrow.
- Renamed `osdPanServoHomeDirectionOffset` to `osdGetPanServoOffset` as the function does not reference home direction. So it can be used elsewhere. - Added pan servo offset to POIs. - Made cardinal always visible for ESP32 Radar.
Updated the `osd_pan_servo_index` max to 16. There are flight controllers now that have 12 PWM outputs. This now matches `MAX_SUPPORTED_SERVOS`.
- Fix bug from merge with master - Reverse pan offset direction arrow
MrD-RC
force-pushed
the
MrD_ESP32-Radar-use-cardinal-markers,-plus-pan-enhancements
branch
from
2084948
to
3b13709
Compare
MrD-RC
deleted the
MrD_ESP32-Radar-use-cardinal-markers,-plus-pan-enhancements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the use of pan servos in INAV. Plus adds enhancements to ESP32 Radar, making it easier to find other pilots.
Since INAV 3.0, we have been able to configure the pan servo, so that the home direction will change based on the direction you are facing. However, setting this up was only in CLI, so many people didn't realise that it existed. This PR brings the configuration in to the OSD page of the Configurator, making setup much simpler. There are also additional OSD elements which can show the direction the pan servo has moved and, optionally, how many degrees. A warning can also be set for close to centre, but not centred. Also, this moving of elements based on pan direction has been extended from only the home position to the elements of the HUD.
The enhancements to ESP32 Radar include replacing the multi arrow direction to the other plane arrow with cardinal indicators. The multi arrows from each side of the HUD element were confusing and not easy to use. The cardinal indicators are much clearer at showing the direction to the other plane. The altitude difference and distance to the other craft have been extended by one digit. For example, altitude difference is now capped at 999, compared to 99.
Before
After
Ideally, these two things would have been developed separately. But, they complimented each other, and the development of the pan enhancements progressed because of that.
Testing required
This PR is pretty much there. I just need to verify that when panning, the OSD elements move the correct way. Initially not having a P&T model, and then video issues, bad weather, and development that took priority has scuppered my plans to test this last piece. Hopefully I can in the next 2 weeks. If not, it will just have to get bumped in to the next version.
Requires configurator iNavFlight/inav-configurator#1691