OSD sidebar height option #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzikuVx
requested changes
Apr 27, 2021
There was a problem hiding this comment.
@breadoven we have to increase the Parameter Group. in osd.c around line 196
PG_REGISTER_WITH_RESET_TEMPLATE(osdConfig_t, osdConfig, PG_OSD_CONFIG, 0);
|
OK, PG updated DzikuVx. |
DzikuVx
approved these changes
Apr 28, 2021
|
@breadoven can you check if your change causes #6990? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue with the current character based OSD sidebars is they take up a lot of space for limited benefit. However, one of the most useful elements of the sidebars, the level indicator arrow that provide a reference for the artificial horizon, are lost if you turn the sidebars off. To get around this problem this PR provides a setting to change the OSD sidebar height. It can be set between 0 to 5 rows, default 3 as now. Setting to 0 completely removes the sidebars leaving just the level indicator arrows.
Although this change could be applicable for the pixel OSD it's currently limited to the character OSD because I don't have a pixel OSD to test. Perhaps if this can be tested, in particular for a height of 0 (set by
OSD_AH_SIDEBAR_HEIGHT_POS) then this change could be updated to include the pixel OSD.