-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for local plus codes on osd #6469
Conversation
|
This is fantastic, thanks for implementing it! |
Do you think it could be useful to also have options to chop off 2 or 6 digits? Removing two digits would work for basically everyone in the RC hobby and 6 digits could be useful if you only fly around a field. |
Personally I think removing 6 digits is overkill, and I always like to have fewer knobs with sane defaults, rather than more. I think 4 digits plus a feature within 40km is fine, and I think Google maps has better support for that, though I'm not entirely sure about that. |
I've checked and google maps works for any shortened plus code. 2km to the reference point is definitely too far for long range flyers but for those that stay within VLOS (all of us of course) this allows to save a bit more OSD space. |
If it would be more useful to you, that's fine with me (but I'm also fine with the longer code). Then again, I'm not an INAV developer so I have no authority. |
Using the text-based setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have to bump PG version in PG_REGISTER_WITH_RESET_TEMPLATE(osdConfig_t, osdConfig, PG_OSD_CONFIG, 13);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avsaase please resolve conflict and we can merge it right after
ah no, no conflict after all, my bad, merging |
Thanks Paweł. |
This PR resolves #5114 by implementing a CLI command
osd_plus_code_type
with optionsGLOBAL
(the default) andLOCAL
, whereLOCAL
chops off the first four digits of the plus code. To find the original location you'll need a reference point like a nearby city or mountain within 0.4 degrees longitude and 0.4 latitude, roughly 40 km.The configurator does not yet understand this option so it doesn't allow placing the shorter plus code against the right edge of the screen. To position the osd element like in this screengrab you need to use CLI commandConfigurator side: iNavFlight/inav-configurator#1150.osd_layout 0 97 21 12 V
.