Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Logic Conditions to override RC channels #6341

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Nov 25, 2020

replaces #5627

@avsaase
Copy link
Member

avsaase commented Dec 26, 2020

I noticed there already is a SET RC CHANNEL logic condition in the configurator. Did that slip in by mistake?

@DzikuVx
Copy link
Member Author

DzikuVx commented Dec 26, 2020

@avsaase it's SET VTX CHANNEL not RC Channel

@avsaase
Copy link
Member

avsaase commented Dec 26, 2020

Using the 2.6 release on Windows:
2020-12-26 22_44_43-INAV Configurator

@avsaase
Copy link
Member

avsaase commented Jan 9, 2021

There are a bunch of questions on RCG and FB about this. To be clear, overriding RC channels is not yet supported in 2.6 right?

@DzikuVx
Copy link
Member Author

DzikuVx commented Jan 9, 2021

@avsaase No it is not in 2.6 I think I will merge this code after extra series of tests and adding a HUGE disclaimer that overriding RC channel can cause crash or injury

@avsaase
Copy link
Member

avsaase commented Jan 9, 2021

Okay then something must have gone wrong when the configurator was build because I've seen multiple posts from people trying to get this to work.

@kernel-machine
Copy link
Contributor

Me too today I've downloaded inav configurator and the option SET RC CHANNEL is present

@cpnmercury
Copy link

hey Pawel, hope your leg is getting better.
Wondering if this code i merged in the latest nightly? Would like it to overide a RC channel on a MR, have a servo on it for camera tilt. But I can't get it to override the channel

@DzikuVx
Copy link
Member Author

DzikuVx commented Feb 19, 2021

@cpnmercury we do not release official nightlies. If you, however, build from master it will be there

@DzikuVx DzikuVx deleted the dzikuvx-lc-rc-channels-override branch February 19, 2021 08:10
@stronnag
Copy link
Collaborator

hey Pawel, hope your leg is getting better.
Wondering if this code i merged in the latest nightly? Would like it to overide a RC channel on a MR, have a servo on it for camera tilt. But I can't get it to override the channel

@cpnmercury we do not release official nightlies. If you, however, build from master it will be there

Unofficially, E&OE etc. http://seyrsnys.myzen.co.uk/inav_dev/

t413 added a commit to t413/inav that referenced this pull request Feb 25, 2021
- also adds docs for the new RC overrides iNavFlight#6341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants