Add PT1 filter option to gyro soft lpf #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo892
added
the
Feedback required
|
It's like going back in time :) |
giacomo892
force-pushed
the
PT1_gyro_filters_giacomo892
branch
from
e7a11d4
to
ad946f9
Compare
Perhaps faster loop times and better builds will let us benefit from less filtering and so less delay? |
|
I'm very much willing to test it over the weekend |
|
@DzikuVx Thanks. Weather will not very good here. Also I tought adding the same to the 2nd stage filter, but that doesn't seems a biquad like main LPF. Why is it different from the 1st LPF (which is actually the second in the chain LOL)? |
DzikuVx
requested changes
Mar 8, 2019
|
BiQuad:
PT1:
|
DzikuVx
approved these changes
Mar 8, 2019
giacomo892
removed
the
Feedback required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the possibility to choose between PT1 and BIQUAD lfp to filter gyro signals.
Configurator support is still missing, if we will ever need it.