Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD system message improvements #10090

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

breadoven
Copy link
Collaborator

@breadoven breadoven commented May 27, 2024

Mainly cleans up OSD system messages according to craft type plus following changes.

The maximum number of messages possible is defined for the main different message categories to clarify the maximum total number of messages possible. Maximum messages possible is currently 6 although this includes a "Save Settings" message which is only displayed briefly so really there should normally be no more than 5 messages.

Fixed wing modes Autotrim, Autotune and Auto Level have been prioritised so only one mode can be active at a time reducing 3 potential mode activation messages being displayed together down to a single message. Priority has been set to Autotune->Autotrim->Autolevel.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 27, 2024

I don't think the consolidation of the auto trim/tune/level trim is needed. They should be used separately.

@breadoven
Copy link
Collaborator Author

I don't think the consolidation of the auto trim/tune/level trim is needed. They should be used separately.

A better solution would be to only allow a single mode to be active at a time. There's no reason they should be active at the same time given what they do, they interfere with each other.

@0crap
Copy link
Contributor

0crap commented May 28, 2024

I don't think the consolidation of the auto trim/tune/level trim is needed. They should be used separately.

Agreed.
Definitely not an improvement for the end user and will only lead to confusion.
Why the need to change this and not leave it as it is? It's working fine now...

@breadoven
Copy link
Collaborator Author

I don't think the consolidation of the auto trim/tune/level trim is needed. They should be used separately.

Agreed. Definitely not an improvement for the end user and will only lead to confusion. Why the need to change this and not leave it as it is? It's working fine now...

It's to reduce the number of potential messages to keep message overload to a minimum. As mentioned above though, the better solution is to prioritise these fixed wing auto tune/trim modes so only one can be selected at a time. Unless I'm missing something I can't see any reason why you'd want to use even 2 of them together at the same time.

@breadoven
Copy link
Collaborator Author

Any objections to merging this ?

@0crap
Copy link
Contributor

0crap commented Jun 18, 2024

If I still see the OSD message Autotrim, Autotune and Auto Level when activated I'm fine.

@breadoven
Copy link
Collaborator Author

If I still see the OSD message Autotrim, Autotune and Auto Level when activated I'm fine.

The messages will appear as they did before but you'll only be able to select one of the modes at a time. Guess I'll just merge and wait to see if there are any complaints.

@breadoven breadoven merged commit a4de24d into iNavFlight:master Jun 18, 2024
21 checks passed
@breadoven breadoven added this to the 8.0 milestone Jun 21, 2024
@breadoven breadoven deleted the abo_osd_sys_msg_cleanup branch September 12, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants