Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary sensor and remove parts from normal sensor #6

Merged
merged 5 commits into from
Jun 4, 2020
Merged

Add binary sensor and remove parts from normal sensor #6

merged 5 commits into from
Jun 4, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jun 4, 2020

No description provided.

vlebourl
vlebourl approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@vlebourl vlebourl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't try it myself as I don't own any of those devices, but the code looks fine to me.

@iMicknl
Copy link
Owner Author

iMicknl commented Jun 4, 2020

@vlebourl it won't work yet, since there are no mappings for binary_sensors in TAHOMA_TYPES. It is something we need to crowdsource. :-)

@iMicknl iMicknl merged commit 908ccfe into master Jun 4, 2020
@iMicknl iMicknl deleted the add_binary_sensor branch June 4, 2020 13:03
@vlebourl vlebourl added the enhancement New feature or request label Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlebourl vlebourl vlebourl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMicknl @vlebourl