Refactor cover platform #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # custom_components/tahoma/const.py
vlebourl
approved these changes
Jun 5, 2020
| @@ -10,11 +10,11 @@ This component is an updated version of the [original Tahoma integration](https: | |||
|
|
|||
| ### Manual | |||
|
|
|||
| Copy the `custom_components/tahoma` to your `custom_components` folder. Reboot home assistant and install the Tahoma integration via the integrations config flow. | |||
| Copy the `custom_components/tahoma` to your `custom_components` folder. Reboot Home Assistant and install the Tahoma integration via the integrations page. | |||
There was a problem hiding this comment.
I would say "configure the Tahoma integration" instead of "install"
There was a problem hiding this comment.
Can you give it some love in another PR? I guess there are more parts that benefit from more clear text, especially around how to install beta's and the risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all hardcoded device strings, basing the supported features on the available states and commands. The main thing I am worried about is the
HorizontalAwningIOComponentwhere it looks like it should be reversed, but I am not sure.@vlebourl could you give it a try?