Use cookie for authentication #167

Cruguah · 2023-02-22T18:51:45Z

This pull request:

adds issue_token / cookies authentication + tests
fixes the is_online key

iMicknl · 2023-02-25T11:07:46Z

@Cruguah one of the main reasons why this PR didn't get merged yet (even as pre release / test) is because this will break the authentication for current users that are still using the auth token method. I am looking if we can combine this and only update the Config Flow for new users.

iMicknl · 2023-02-25T11:08:44Z

CI/CD failing on R] [MANIFEST] Manifest keys have been sorted: domain, name, then alphabetical order. I will fix this in main branch so you can just rebase. This is a new requirement from core.

iMicknl

Looks good. Some comments to get the review started. I will try to make some time to test this PR myself as well asap, so we can start merging this in.

iMicknl · 2023-02-25T13:27:11Z

.vscode/settings.json

@@ -1,9 +1,30 @@
 {


Can you revert the changes here? They don't seem necessary for this PR.

README.md

custom_components/nest_protect/binary_sensor.py

custom_components/nest_protect/manifest.json

iMicknl · 2023-03-14T15:40:01Z

Thanks a lot and good to see all checks are green. I will see if we can merge this in a beta branch, to keep this code in this repository as well.

In order to be merged to main, the following issues would need to be fixed first: beta (cookie-method) Using the cookie method branch

Cruguah · 2023-04-05T14:43:12Z

@iMicknl, I've implemented a reconfiguration option to renew the issue_token and cookie. Would you be so kind to update you HA instance with this version to see if that works?

You can reinstall the nest integration using HACS by reinstalling the current integration, Open the integration and click on:

Then you can find the (re)configure option in the integration:

Hope this helps!

spyfly · 2023-04-22T15:28:04Z

Would be nice if this could finally be merged so that cookie auth can be utilised.

wafliron · 2023-04-26T08:24:18Z

PS. wafliron, if you are using the latest version (and you need to check this manualy) it will continue to work.

Thanks @Cruguah.

Must admit I'm confused by the versioning/forks of this PR/integration (and confused about correct terminology!), but for the record I'm currently using the fork at https://github.com/nicoinch/ha-nest-protect (re-installed it 1-2 weeks ago).

For the benefit of anyone else reading this now/in the future: the above fork continued to work (with cookie auth) after upgrading past 2023.02 (to 2023.04.05). The warning "Detected integration that called async_setup_platforms instead of awaiting async_forward_entry_setups; this will fail in version 2023.3" persists in the logs, but it doesn't appear to have actually failed / broken anything obvious (confirmed at least the occupancy sensors from my Nest Protects continue to update properly in HA).

iMicknl

I can't edit your branch unfortunately, so trying to fix your linting issues via interface..

iMicknl · 2023-04-26T10:43:07Z

custom_components/nest_protect/config_flow.py

@@ -1,26 +1,30 @@
 """Adds config flow for Nest Protect."""
 from __future__ import annotations


Suggested change

from __future__ import annotations

from __future__ import annotations

iMicknl · 2023-04-26T10:43:15Z

custom_components/nest_protect/config_flow.py

@@ -1,26 +1,30 @@
 """Adds config flow for Nest Protect."""
 from __future__ import annotations
-
 from typing import Any, cast


Suggested change

from typing import Any, cast

from typing import Any, cast

iMicknl · 2023-04-26T10:43:22Z

custom_components/nest_protect/config_flow.py

 from .pynest.client import NestClient
 from .pynest.const import NEST_ENVIRONMENTS
 from .pynest.exceptions import BadCredentialsException
+import voluptuous as vol


Suggested change

import voluptuous as vol

iMicknl · 2023-04-26T10:45:34Z

.github/workflows/pre-commit.yml

@@ -2,7 +2,7 @@ name: Linters (flake8, black, isort)

 on:
  pull_request:
-
+  


Suggested change

iMicknl · 2023-04-26T10:49:59Z

@Cruguah could you unprotect your main branch? You did your PR from the main branch, and thus I cannot help you and make changes. My proposal would be to fix this PR, bring it to beta branch and release this one as prerelease, so that HACS users can easily install and we can do version management.

Cruguah · 2023-04-26T10:51:24Z

@Cruguah could you unprotect your main branch? You did your PR from the main branch, and thus I cannot help you and make changes. My proposal would be to fix this PR, bring it to beta branch and release this one as prerelease, so that HACS users can easily install and we can do version management.

I just did it!

iMicknl · 2023-04-26T10:54:12Z

@Cruguah not yet "You can’t commit to main because it is a protected branch". You can override this as admin, but you would need to remove the protection (or do the PR from another branch), for me to be able to help.

Cruguah · 2023-04-26T11:14:01Z

Ok, this looks better!

iMicknl · 2023-04-26T11:23:59Z

@Cruguah see

Cruguah · 2023-04-26T11:48:51Z

Yep, and installed this beta version.
I'll keep an eye on the logfile, but up until now, all looks good!

iMicknl · 2023-04-26T12:24:17Z

I tagged all issues with https://github.com/iMicknl/ha-nest-protect/issues?q=is%3Aissue+is%3Aopen+label%3A%22beta+%28cookie-method%29%22, so that we can easily track which issues we need to resolve to merge to main.

wafliron · 2023-04-28T10:32:16Z

Confirming that after upgrading to 0.4.0b1 my Nest Protects have continued to work fine in HA and the async_setup_platforms warning is gone. Thanks for your work on this @iMicknl and @Cruguah.

m4v3r1ckNl · 2023-07-10T07:18:26Z

My Nest Protect integration (2) were broken since 2023.6.x but now HA is on 2023.7.1. Is the use of the BETA 0.4.0b1 still valid for my version of HA?

iMicknl · 2023-07-10T07:28:50Z

@m4v3r1ckNl you are using the fork, not my version if it was broken. Remove the custom repository from HACS and install beta 0.4.0b2.

m4v3r1ckNl · 2023-07-11T11:38:41Z

Thank you @iMicknl for your reply, but I'm not sure which version (forked) I installed. I used your cookie auth method on my instance of Nest Protect. Please see my screencap. All was functioning 100%.

iMicknl · 2023-07-11T16:57:49Z

@m4v3r1ckNl please create a new issue if you face issues. However, if you follow my instructions (remove the custom repository), it should be fixed.

m4v3r1ckNl · 2023-07-13T21:02:56Z

Thank you @iMicknl I'll give that a try, the current integration is broken anyway. Cheers

m4v3r1ckNl · 2023-08-01T10:05:15Z

Hi @iMicknl

Up-and-running again. Deleted the nest_protect under custom components and reinstalled the beta 0.4.0b2 today.

Thank you for your help!

nicoinch and others added 11 commits November 30, 2022 09:45

Use cookie for authentication

1e62797

Merged changes from nicoinch

caf7e9e

Merge branch 'nicoinch-main'

ff77883

Resolved some warnings

1e3ecc7

Resolved a spelling error

c656727

Update pre-commit.yml

1d7eae2

Update pre-commit.yml

8188f90

Update pre-commit.yml

5a5f8a1

Update pre-commit.yml

1219049

Resolve lint issues

4c0603b

Merge branch 'main' of https://github.com/Cruguah/ha-nest-protect

c9c29d5

Cruguah requested a review from iMicknl as a code owner February 22, 2023 18:51

Update pre-commit.yml

087d19a

iMicknl requested changes Feb 25, 2023

View reviewed changes

Cruguah added 2 commits February 25, 2023 21:36

processed review comments

52a1f40

Merge branch 'main' of https://github.com/Cruguah/ha-nest-protect

ffd9bff

This was referenced Feb 26, 2023

Implement reauth flow (reconfigure) on USER_LOGGED_OUT #170

Closed

async_setup_platforms instead of awaiting async_forward_entry_setups; this will fail in version 2023.3. #179

Closed

Cruguah added 3 commits March 8, 2023 14:59

Resolved a validation issue

fbf9865

Remove the version number

3d83a84

Added the version tag again

7ecb075

iMicknl changed the base branch from main to cookie-login March 14, 2023 15:40

Cruguah added 3 commits March 27, 2023 22:27

Solved multiple issues

49657a7

Resolve lint issues

eac9513

Added reconfiguration to the nest integration

18e0214

Try to solve the partial upgrade of isort config

76ba32f

iMicknl mentioned this pull request Apr 26, 2023

Use cookie for authentication #121

Closed

iMicknl reviewed Apr 26, 2023

View reviewed changes

.github/workflows/pre-commit.yml Outdated

@@ -2,7 +2,7 @@ name: Linters (flake8, black, isort)

on:

pull_request:

Copy link

Owner

iMicknl Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

iMicknl changed the base branch from beta to main April 26, 2023 10:47

iMicknl changed the base branch from main to beta April 26, 2023 10:47

Cruguah and others added 6 commits April 26, 2023 13:02

Try to resolve pre-check errors

94f3a82

Merge branch 'beta' into main

4cfcc16

Resolve a conflict

ffe7a25

Merge branch 'main' of https://github.com/Cruguah/ha-nest-protect

1e19d6e

Revert changes

9798b60

Update settings.json

7221d01

iMicknl merged commit 4b3f2cc into iMicknl:beta Apr 26, 2023

iMicknl pushed a commit that referenced this pull request Aug 13, 2023

Use cookie for authentication (#167)

4818f5d

iMicknl pushed a commit that referenced this pull request Jan 27, 2024

Use cookie for authentication (#167)

796167b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use cookie for authentication #167

Use cookie for authentication #167

Cruguah commented Feb 22, 2023

iMicknl commented Feb 25, 2023

iMicknl commented Feb 25, 2023

iMicknl left a comment

iMicknl Feb 25, 2023

Cruguah Feb 25, 2023

iMicknl commented Mar 14, 2023

Cruguah commented Apr 5, 2023

spyfly commented Apr 22, 2023

wafliron commented Apr 26, 2023

iMicknl left a comment

iMicknl Apr 26, 2023

iMicknl Apr 26, 2023

iMicknl Apr 26, 2023

iMicknl Apr 26, 2023

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

wafliron commented Apr 28, 2023

m4v3r1ckNl commented Jul 10, 2023

iMicknl commented Jul 10, 2023

m4v3r1ckNl commented Jul 11, 2023

iMicknl commented Jul 11, 2023

m4v3r1ckNl commented Jul 13, 2023

m4v3r1ckNl commented Aug 1, 2023

		@@ -1,26 +1,30 @@
		"""Adds config flow for Nest Protect."""
		from __future__ import annotations

		@@ -2,7 +2,7 @@ name: Linters (flake8, black, isort)

		on:
		pull_request:

Use cookie for authentication #167

Use cookie for authentication #167

Conversation

Cruguah commented Feb 22, 2023

iMicknl commented Feb 25, 2023

iMicknl commented Feb 25, 2023

iMicknl left a comment

Choose a reason for hiding this comment

iMicknl Feb 25, 2023

Choose a reason for hiding this comment

Cruguah Feb 25, 2023

Choose a reason for hiding this comment

iMicknl commented Mar 14, 2023

Cruguah commented Apr 5, 2023

spyfly commented Apr 22, 2023

wafliron commented Apr 26, 2023

iMicknl left a comment

Choose a reason for hiding this comment

iMicknl Apr 26, 2023

Choose a reason for hiding this comment

iMicknl Apr 26, 2023

Choose a reason for hiding this comment

iMicknl Apr 26, 2023

Choose a reason for hiding this comment

iMicknl Apr 26, 2023

Choose a reason for hiding this comment

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

Cruguah commented Apr 26, 2023

iMicknl commented Apr 26, 2023

wafliron commented Apr 28, 2023

m4v3r1ckNl commented Jul 10, 2023

iMicknl commented Jul 10, 2023

m4v3r1ckNl commented Jul 11, 2023

iMicknl commented Jul 11, 2023

m4v3r1ckNl commented Jul 13, 2023

m4v3r1ckNl commented Aug 1, 2023