Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processor: throw exception if parameter is already defined for given … #15

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Processor: throw exception if parameter is already defined for given … #15

merged 2 commits into from
Jun 23, 2017

Conversation

andresailer
Copy link
Contributor

…processor

Fixes #14

Beyond iLCSoft/MarlinReco#13 and iLCSoft/MarlinTrkProcessors#18 nothing showed up

BEGINRELEASENOTES

  • Processor: throw exception if parameter is already defined

ENDRELEASENOTES

@gaede
Copy link
Contributor

gaede commented Jun 23, 2017

Can you please add the same check here:
https://github.com/iLCSoft/Marlin/blob/master/source/include/marlin/Processor.h#L307-L316

@andresailer
Processor: check also for registerOptionalProcessor
7dbaae3 
move logic for check to separate function
@andresailer
Copy link
Contributor Author

Done

gaede
gaede approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gaede gaede merged commit 56977b8 into iLCSoft:master Jun 23, 2017
@andresailer andresailer deleted the duplPara branch April 10, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresailer @gaede