Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forceInclude option for :where selectors #11

Closed
wants to merge 2 commits into from
Closed

Add forceInclude option for :where selectors #11

wants to merge 2 commits into from

Commits on May 11, 2023

  1. Add forceInclude option for :where selectors 

    For some reason, penthouse doesn't think that :where selectors are not
part of the critical css. Let's add it to the config so that it includes
the :where selectors in the generated critical css.

See iFixit/ifixit#47766 (comment) for more info.
    @batbattur
    batbattur committed May 11, 2023
    Configuration menu
    Copy the full SHA
    18eb07c View commit details
    Browse the repository at this point in the history

  2. Update the forceInclude regex to be specific 

    This new regex will match selectors like the following:
:where(), :has(), :not(), :host(), :root().

Verified that it will not match selectors like the following:
li(:last-child), .green:not(:disabled), .card-hover:hover.
    @batbattur
    batbattur committed May 11, 2023
    Configuration menu
    Copy the full SHA
    80656ab View commit details
    Browse the repository at this point in the history