Fixes for large Servers #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One thing that is a constant problem is on multiplayer servers morphs is preventing them to startup after a while. As we know very well that NBT data files can be huge without problems, it can only mean one thing, the HashMap. It can be efficient to store all data in single player servers on a hash map until the server is restarted as you only have 1 - 5 players on. But this becomes problematic on large servers that have thousands of players. If all players joined throughout a day are kept loaded in the map even if they are not on, would result in a large amount of lag due to space required to hold everything in a map. A solution is to remove the player from the map on logout, as this prevents server owners from having to do constant restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that is a constant problem is on multiplayer servers morphs is preventing them to startup after a while. As we know very well that NBT data files can be huge without problems, it can only mean one thing, the HashMap. It can be efficient to store all data in single player servers on a hash map until the server is restarted as you only have 1 - 5 players on. But this becomes problematic on large servers that have thousands of players. If all players joined throughout a day are kept loaded in the map even if they are not on, would result in a large amount of lag due to space required to hold everything in a map. A solution is to remove the player from the map on logout, as this prevents server owners from having to do constant restarts.