Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for ipython #288

Merged
merged 1 commit into from
Nov 25, 2024
Merged

bug fix for ipython #288

merged 1 commit into from
Nov 25, 2024

Conversation

chStaiger
Copy link
Collaborator

Previously, there was password prompt and textfield in the jupyter lab when the password needs to be provided.
Now the command shows the prompt 3 times but there is no password field any longer.

It looks like Jupyter lab does not return True for sys.stdin.isatty() any longer.
The first case in interactive_auth which uses getpass can also be triggered by

if sys.stdin.isatty() or 'ipykernel' in sys.modules

Which will open the password prompt in jupyter labs and notebooks.

Tested in jupyter lab, on commandline and in interactive python. I also tested the pipeing of the password to ibridges init.
All works.

@chStaiger chStaiger linked an issue Nov 25, 2024 that may be closed by this pull request
@chStaiger chStaiger requested a review from qubixes November 25, 2024 08:34
@chStaiger chStaiger merged commit 50293b4 into develop Nov 25, 2024
12 checks passed
@chStaiger chStaiger deleted the 287-pw-in-jupyter branch November 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password prompt does not work in Jupyterlab
2 participants