Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata blacklist #279

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Metadata blacklist #279

merged 4 commits into from
Oct 31, 2024

Conversation

chStaiger
Copy link
Collaborator

To protect the Yoda system metadata which starts with "org_" we introduced a blacklist in the metadata class.

One can omit blacklisting by setting blacklist = None. However, there was a little bug, which led to not being able to print the metadata.
I also introduced the checking of the blacklist when a new metadata item is created.

@chStaiger chStaiger requested a review from qubixes October 25, 2024 14:40
@chStaiger chStaiger closed this Oct 25, 2024
@chStaiger chStaiger reopened this Oct 25, 2024
@chStaiger chStaiger mentioned this pull request Oct 25, 2024
Copy link
Collaborator

@qubixes qubixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it does seem like I missed a return statement there! Just some small suggestions to make the code easier to read.

docs/source/faq.rst Outdated Show resolved Hide resolved
ibridges/meta.py Show resolved Hide resolved
ibridges/meta.py Show resolved Hide resolved
@chStaiger chStaiger merged commit ad70ef4 into develop Oct 31, 2024
12 checks passed
@chStaiger chStaiger deleted the blacklist_org branch October 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants