Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use apiLevel instead of forceApi when building the apk #3399

Merged
merged 1 commit into from
Oct 11, 2023
Merged

use apiLevel instead of forceApi when building the apk #3399

merged 1 commit into from
Oct 11, 2023

Conversation

JoshMiers-FS
Copy link
Contributor

@JoshMiers-FS JoshMiers-FS commented Oct 11, 2023

The change in PR #3100 made it so forceApi was not set anymore. However, the code to build an APK with a specific API level was not updated, causing issues where a newer API level is required.

This PR completely removes forceApi and uses the existing apiLevel config value.

@iBotPeaches
Copy link
Owner

thanks for the find. Looks like an embarrassing thing I missed in that review.

@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Oct 11, 2023
@iBotPeaches iBotPeaches merged commit e2a5742 into iBotPeaches:master Oct 11, 2023
31 checks passed
iBotPeaches added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants