Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: patch aapt2 to ignore private resources (unix/win) #3396

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Oct 11, 2023

partially fixes #3392 with this aapt2 patch: iBotPeaches/platform_frameworks_base@33b73df
fixes: #3421

@iBotPeaches iBotPeaches marked this pull request as ready for review November 8, 2023 11:22
@iBotPeaches iBotPeaches merged commit 9e9079d into master Nov 8, 2023
25 checks passed
@iBotPeaches iBotPeaches deleted the private-aapt2 branch November 8, 2023 11:30
@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Nov 8, 2023
@dmitryuk
Copy link

Any chance to be released soon?

@iBotPeaches
Copy link
Owner Author

Any chance to be released soon?

Aiming late December release.

@dmitryuk
Copy link

Will be so appreciated if you will make a release soon

@iBotPeaches
Copy link
Owner Author

Will be so appreciated if you will make a release soon

December is soon :)

@HassanMirza01
Copy link

This going to solve such erros too ?

image

@iBotPeaches
Copy link
Owner Author

This going to solve such erros too ?

image

That doesn't look like it has anything to do with private resources. So no.

@HassanMirza01
Copy link

That doesn't look like it has anything to do with private resources. So no.

should i open separate issue ? its an issue with attrs not being unpacked correctly, neither in attrs.xml and hence nor in public.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recompile error [BUG] Cannot recompile Pixel SystemUI
3 participants