Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2806
Apktool was outputting:
When its clear looking at aapt2 that we should have some values there.
This was clearly missing something. This was first detected a long time ago in: #1994
It was partially fixed in #2000, but original author was nervous of the old logic. Now that I had some time I realized old logic was just guessing the factory to use.
Now we rely on the type. Which makes the code a bit more elegant and fixes the mentioned issue.