fix: support skipping entries with NO_ENTRY (-1) flag #3209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1874
In a very old (5+ year) issue. We saw a specific version of Google Hangouts failed to decode. Turns out with some fresh eyes. We just missed an important note in the spec that we should skip entries if the key/offset resolve to -1 (NO_ENTRY)
We applied that to the entry reading as well as the offset reading and it worked great to resolve what used to be this crash: