Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move AndrolidExceptions to the package brut.androlib.exceptions #3088

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

sv99
Copy link
Contributor

@sv99 sv99 commented Jun 6, 2023

  1. move AndrolidExceptions to the package brut.androlib.err
  2. rename brut.androlib.err to brut.androlib.exceptions

@sv99
Copy link
Contributor Author

sv99 commented Jun 6, 2023

Some strang errors in the CI / Build/Tests??

@iBotPeaches
Copy link
Owner

Some strang errors in the CI / Build/Tests??

Restarted build

@iBotPeaches
Copy link
Owner

@sv99 - Do you have any background for this? Is this a better nomenclature to follow? Some older design pattern that is outdated? A proper naming convention instead of err?

@sv99
Copy link
Contributor Author

sv99 commented Jun 7, 2023

Yes I think this is standard naming convention for Exceptions.

Further, I think extract all configuration for androlib object in the Config class.
Config.getDefautConfig() for default config options and change this object by command line params.

Config class based on BuildOptions.

@iBotPeaches
Copy link
Owner

Further, I think extract all configuration for androlib object in the Config class. Config.getDefautConfig() for default config options and change this object by command line params.

Config class based on BuildOptions.

Yeah I had an idea to fix up decode to match what I started with BuildOptions. It seemed saner to build up a configuration object that Apktool would use then expose 20-30 setters for all the various options. Seemed to encapsulate that better.

@sv99
Copy link
Contributor Author

sv99 commented Jun 7, 2023

Next I thin Androlib and ApkDecoder has some mix functionality.
It seems to me that it would be better to add data class Apk were store all apk data and two different classes ApkReader or ApkDecoder and ApkWriter

The Apk class will allow simply realize a comparison of two Apk before and after convertation

@iBotPeaches iBotPeaches merged commit 168aa1a into iBotPeaches:master Jun 10, 2023
iBotPeaches added a commit that referenced this pull request Jun 10, 2023
@iBotPeaches iBotPeaches added this to the v2.8.0 milestone Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants