-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to include generic/permissive network security config file durin… #2791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think its crucial for this new feature to produce 2 tests that:
- modify an application that already has a network config
- modify an application that does not have one
I understand if the Apktool codebase may not be the easiest to do that, but if you want to take a stab at that it would be appreciated.
Thanks for the PR.
brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/res/xml/ResXmlPatcher.java
Outdated
Show resolved
Hide resolved
brut.apktool/apktool-lib/src/main/java/brut/androlib/res/xml/ResXmlPatcher.java
Outdated
Show resolved
Hide resolved
indeed i was thinking that tests might be useful for it but hesitated to add them initially. I have made a new push with the tests. Used the testapp you already have in there and added the configuration to it. |
I'm going to take the branch from here to slim down the test app to just the basics so we don't replicate the large test application then push up some changes. |
remote add and then cherry-pick: done |
@iBotPeaches any updates here |
Sorry not yet. Appears I broke build w/ my latest patches since I was working on Mac and haven't visited Linux yet. |
@iBotPeaches added them |
@erev0s - okay just just fix that last conflict, which was caused by my merge last night and then good to go. |
@iBotPeaches did a push with what seems to be the conflict. |
Added the flag '-n' as an option to be able to add a generic permissive Network Security Configuration file during the build process. This is based on the following feature request #1622
fixes: #1622