Skip to content

Commit

Permalink
Bug 1822174: set worker implementation in push langpack transform to …
Browse files Browse the repository at this point in the history
…avoid tripping logic that adds extra tags, and breaks CoT verification r=releng-reviewers,ahal a=release

This function (https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/taskcluster/gecko_taskgraph/transforms/job/__init__.py#133) ends up setting the `worker-implementation` tag. This ends up giving us two worker implementation types in scriptworker (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L331), which ultimately causes us to hit this exception (https://github.com/mozilla-releng/scriptworker/blob/b895fdd92b712958b8dba41d7fb8c4b162bc948b/src/scriptworker/cot/verify.py#L375)

(It seems to me that `set_implementation` setting this tag will always cause this issue, so perhaps we need to remove that part of its code. At the very least, we should re-examine this...we support setting implementation and os in multiple places....which is very confusing.)

Differential Revision: https://phabricator.services.mozilla.com/D172477
  • Loading branch information
bhearsum committed Mar 13, 2023
1 parent 5dcc48a commit 0b399ab
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def make_task_worker(config, jobs):
job, expected_kinds=("build", "shippable-l10n")
)

job["worker"]["implementation"] = "push-addons"
job["worker"]["upstream-artifacts"] = generate_upstream_artifacts(
upstream_task_ref, job["attributes"]["chunk_locales"]
)
Expand Down

0 comments on commit 0b399ab

Please sign in to comment.