Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make children optional within TransProps #728

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Make children optional within TransProps #728

merged 2 commits into from
Feb 11, 2019

Conversation

menthena
Copy link
Contributor

@menthena menthena commented Feb 11, 2019 •
edited
Loading

Fixes #727

@menthena menthena mentioned this pull request Feb 11, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.86% when pulling 188f537 on menthena:fix/optional-children into 07c9ea9 on i18next:master.

@rosskevin
Copy link
Collaborator

@menthena please add another usage example that covers the case in test/typescript

@rosskevin rosskevin merged commit e110d37 into i18next:master Feb 11, 2019
@rosskevin
Copy link
Collaborator

@jamuhl this can be a patch release

@menthena menthena deleted the fix/optional-children branch February 11, 2019 14:14
@jamuhl
Copy link
Member

jamuhl commented Feb 11, 2019

published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin Awaiting requested review from rosskevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@menthena @coveralls @rosskevin @jamuhl