Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TS definition for reportNS prop #699

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add TS definition for reportNS prop #699

merged 1 commit into from
Jan 28, 2019

Conversation

johnnynia
Copy link
Contributor

The reportNS prop of I18nextProvider is missing in I18nextProviderProps.

react-i18next/src/I18nextProvider.js

Line 14 in 5e929b5

const { children, i18n, defaultNS, reportNS } = this.props;

It was added in PR #500

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.157% when pulling d62c894 on johnnynia:add-ts-definition-for-reportns into 5e929b5 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin January 27, 2019 16:12
@rosskevin rosskevin merged commit aaab3b2 into i18next:master Jan 28, 2019
@rosskevin
Copy link
Collaborator

@jamuhl this can be a patch release

@johnnynia johnnynia deleted the add-ts-definition-for-reportns branch January 28, 2019 16:27
@jamuhl
Copy link
Member

jamuhl commented Jan 30, 2019

published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnnynia @coveralls @rosskevin @jamuhl