-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript tests with example usage as sanity check and hook into test
script
#655
Conversation
Note, this test proves and fixes a few errors I am seeing downstream in my app. ts users are likely broken due to the bad context type import until this is merged and released. |
I'm still threading through my codebase and finding some fixes, let's hold this until I get a clean run locally. I'll update this issue when ready. |
test
scripttest
script
test
scripttest
script
This PR is ready to merge. |
@jamuhl if we can get this merged and released, I would appreciate it. Incorrect types included in-repo are not easily ignored, whereas they are if they are from definitelytyped (just don't include them). This PR fixes a breaking change for ts users and should get us back to working. |
published in [email protected] |
@rosskevin Do you have time to test also the file for hook type ? You broke them with your PR, cf : #658 |
@VincentLanglet I don't use the hooks yet, but feel free to add usage tests similar to how I did the index. |
Closes #654