Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types to support t function redesign #1615

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Feb 17, 2023

Main PR: i18next/i18next#1911

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@pedrodurek pedrodurek changed the title Update types to support t function redesign Update types to support t function redesign Feb 17, 2023
@adrai
Copy link
Member

adrai commented Feb 17, 2023

fyi: be sure this continuous to work:
https://github.com/i18next/next-13-app-dir-i18next-example-ts/blob/e34e295e55388b8045ce7d00c2de24545c725d72/app/%5Blng%5D/page.tsx#L2
https://github.com/i18next/next-13-app-dir-i18next-example-ts/blob/e34e295e55388b8045ce7d00c2de24545c725d72/app/i18n/index.ts#L3

"types": "./TransWithoutContext.d.ts",

"types": "./initReactI18next.d.ts",

@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2023
@adrai adrai removed the stale label Mar 18, 2023
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 25, 2023
@adrai adrai removed the stale label Mar 25, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 2, 2023
@adrai adrai removed the stale label Apr 2, 2023
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 26, 2023
@adrai adrai removed the stale label Apr 26, 2023
@stale
Copy link

stale bot commented May 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented May 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 10, 2023
@adrai adrai removed the stale label Jun 10, 2023
@adrai adrai marked this pull request as ready for review June 15, 2023 08:31
@adrai adrai merged commit fc027ef into i18next:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants