getWrappedInstance() broken in ^8.0.0

[Jessidhia]

The documentation in the README specifies that you need to call getWrappedInstance() twice; however, neither of the new building blocks used internally by withNamespaces (withI18n, which in turn uses withContext) implement getWrappedInstance(). Even if they did, this would have required 3 chained calls of getWrappedInstance(), not 2.

A better approach would probably be to drop the withRef system entirely and have an innerRef prop that is forwarded as ref in the HOC's render().

[jamuhl]

fully agree had no time yet to search for a solution...but yes...calling getWrappedInstance is no longer an options (out of the reasons you mention).

So if i get your approach right - just passing in a innnerRef function as prop and use that on the ref in rendering

[Jessidhia]

Yeah, it doesn't even have to be a function; react 16.3+'s createRef object should do too.

It's similar to the approach taken by styled-components/emotion.

[jamuhl]

ok...will need to check that...

[Jessidhia]

Even better would be forwardRef but that would require React 16.4+ and at least react-redux had some performance concerns about it: facebook/react#13456

[jamuhl]

seems you know a lot more about refs then me 💪i just try to avoid them personally

[jamuhl]

details for implementation: https://gist.github.com/gaearon/1a018a023347fe1c2476073330cc5509

[jamuhl]

landed in [email protected]

[Jessidhia]

The fix did fix withNamespaces, but withI18n and withContext still have no way to forward the ref to the wrapped component.

Moving the innerRef implementation to withContext's HOC should be sufficient to get support for all 3.

[jamuhl]

@Kovensky should be in [email protected]