Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move hook out of condition #1410

Merged
merged 2 commits into from
Sep 7, 2021
Merged

refactor: Move hook out of condition #1410

merged 2 commits into from
Sep 7, 2021

Conversation

Arnarkari93
Copy link
Contributor

@vercel
Copy link

vercel bot commented Sep 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/isaachinman/next-i18next/Fnjo8vUgnautQ68AKyCeeArGpGVd
✅ Preview: https://next-i18next-git-fork-arnarkari93-fix-condit-5a4677-isaachinman.vercel.app

@isaachinman
Copy link
Contributor

@Arnarkari93 You marked this as a bug fix via semantic titling. Did you actually encounter a bug?

@Arnarkari93
Copy link
Contributor Author

No, I did not encounter a bug. I have no idea how this semantic title thing works I just marked it as a fix as a guess. I can also mark it as a chore if you prefer that.

@isaachinman isaachinman changed the title Move hook out of condition refactor: Move hook out of condition Sep 7, 2021
@isaachinman isaachinman merged commit e7eb577 into i18next:master Sep 7, 2021
@isaachinman
Copy link
Contributor

Thanks @Arnarkari93!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachinman isaachinman isaachinman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arnarkari93 @isaachinman