Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option to disable the non-printable utf8 escaping #685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cslecours
Copy link

@cslecours cslecours commented Nov 9, 2022

Why am I submitting this PR

In my project, when I run i18next-parser, I get the converted entities, however, my automated translation tool converts them back to the non-escaped sequence.

This has become a little dance where as soon as I merge the translations I get another PR from the service to change it back.

Does it fix an existing ticket?

Yes/No #000

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@cslecours cslecours marked this pull request as ready for review November 9, 2022 22:23
@cslecours
Copy link
Author

cslecours commented Nov 9, 2022

This is only a proof of concept : if the idea is approved, I can get the PR in a state where it's ready to merge, but I would not waste too much time if it's not the case :)

In my repo I have removed this part using patch-package so it's not urgent to merge.

@karellm
Copy link
Member

karellm commented Nov 11, 2022

Thanks for the PR. If you add a test for the new behaviour, I'll be happy to merge it.

@brianmotherway
Copy link

Is there any update on this being merged? We're having issues with this affecting every commit we try to do in our codebase

@karellm
Copy link
Member

karellm commented Jan 30, 2023

@brianmotherway The change is not tested. If you want to take over the PR and write a test for it, I'll review and merge it

@cslecours
Copy link
Author

@brianmotherway, if you write the tests that would be super helpful! 🙏

@karellm karellm force-pushed the master branch 2 times, most recently from d72e758 to 10f3d69 Compare May 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants