-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support .ts, .json and .yaml config #673
Conversation
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Here is one unit test failed. But I believe it is not related to my changes. |
Codecov ReportBase: 95.39% // Head: 93.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 95.39% 93.84% -1.56%
==========================================
Files 11 11
Lines 1650 1689 +39
==========================================
+ Hits 1574 1585 +11
- Misses 76 104 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Can you remove the console.log ?
src/helpers.js
Outdated
} | ||
|
||
async function tsConfigLoader(filepath) { | ||
console.log(filepath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console.log
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Published as |
Why am I submitting this PR
support .ts, .json and .yaml config
Does it fix an existing ticket?
No
Checklist
yarn test
(see details here)