Make sure empty namespace files are an empty object (not an empty str…

…ing) Fix #273

src/helpers.js

@@ -12,6 +12,8 @@
  * different value, or `false`.
  */
 function dotPathToHash(entry, target = {}, options = {}) {
+  let conflict = false
+  let duplicate = false
   let path = entry.keyWithNamespace
   if (options.suffix || options.suffix === 0) {
     path += `${options.pluralSeparator}${options.suffix}`
@@ -24,6 +26,12 @@ function dotPathToHash(entry, target = {}, options = {}) {
     entry.keyWithNamespace.length
   )
 
+  // There is no key to process so we return an empty object
+  if (!key) {
+    target[entry.namespace] = {}
+    return { target, duplicate, conflict }
+  }
+
   const defaultValue =
     typeof options.value === 'function'
       ? options.value(options.locale, entry.namespace, key)
@@ -59,7 +67,6 @@ function dotPathToHash(entry, target = {}, options = {}) {
 
   const segments = path.split(separator)
   let inner = target
-  let conflict = false
   for (let i = 0; i < segments.length - 1; i += 1) {
     const segment = segments[i]
     if (segment) {
@@ -78,7 +85,7 @@ function dotPathToHash(entry, target = {}, options = {}) {
   if (oldValue !== undefined && oldValue !== newValue) {
     conflict = typeof oldValue !== typeof newValue ? 'key' : 'value'
   }
-  const duplicate = oldValue !== undefined || conflict !== false
+  duplicate = oldValue !== undefined || conflict !== false
 
   if (options.customValueTemplate) {
     inner[lastSegment] = {}

test/helpers/dotPathToHash.test.js

@@ -45,6 +45,15 @@ describe('dotPathToHash helper function', () => {
     done()
   })
 
+  it('handles an empty namespace', (done) => {
+    const { target, duplicate } = dotPathToHash(
+      { keyWithNamespace: 'ns.', namespace: 'ns' }
+    )
+    assert.deepEqual(target, { ns: {} })
+    assert.equal(duplicate, false)
+    done()
+  })
+
   it('handles a target hash', (done) => {
     const { target, duplicate } = dotPathToHash(
       { keyWithNamespace: 'one.two.three' },

test/manual/html.html

@@ -27,6 +27,7 @@
     >asd</p>
     <p data-i18n="seventh" data-i18n-options='{"defaultValue": "foo"}'>Seventh</p>
     <p data-i18n="seventh" data-i18n-options='{"defaultValue": "bar"}'>Seventh</p>
+    <p data-i18n="empty:">Empty</p>
   </div>
 </body>
 </html>

test/parser.test.js

@@ -292,6 +292,41 @@ describe('parser', () => {
     i18nextParser.end(fakeFile)
   })
 
+  it('creates an empty namespace file if no key is provided', (done) => {
+    let results = []
+    let resultContent
+    const i18nextParser = new i18nTransform({
+      locales: ['en'],
+      defaultNamespace: 'default',
+    })
+    const fakeFile = new Vinyl({
+      contents: Buffer.from("t('empty:');"),
+      path: 'file.js',
+    })
+
+    i18nextParser.on('data', (file) => {
+      if (file.relative.endsWith(path.normalize('en/empty.json'))) {
+        resultContent = JSON.parse(file.contents)
+      }
+      results.push(file.relative.replace(/locales[\//\\]/, ''))
+    })
+    i18nextParser.on('end', () => {
+      const expectedFiles = [
+        'en/empty.json'
+      ]
+      let length = expectedFiles.length
+
+      assert.equal(results.length, 1)
+      assert.deepEqual(resultContent, {})
+      for (const filename of expectedFiles) {
+        assert.include(results, path.normalize(filename))
+        if (!--length) done()
+      }
+    })
+
+    i18nextParser.end(fakeFile)
+  })
+
   it('applies withTranslation namespace globally', (done) => {
     let result
     const i18nextParser = new i18nTransform()